CI: fix mypy errors #977
Merged
CI: fix mypy errors #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
reviewed
Feb 8, 2024
There was a problem hiding this comment.
I might have a slight preference for leaving the markers and disabling the error code:
--- a/darshan-util/pydarshan/mypy.ini
+++ b/darshan-util/pydarshan/mypy.ini
@@ -45,3 +45,6 @@ ignore_missing_imports = True
[mypy-darshan.backend.cffi_backend]
ignore_errors = True
+
+[mypy-darshan.tests.*]
+disable_error_code = attr-definedI think what happened is that pytest 8.0.0 was released with more typing support, since we didn't change much on our end.
|
That works for me, too, thanks for the suggestion. I've just pushed in that change and will merge assuming everything passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're getting errors like this in the PyDarshan CI now related to the mypy step:
which I think is caused by injecting variables into pytest (and later referencing them in tests), like in
conftest.py:As a temporary workaround, just remove offending pytest
skipifdecorators -- it looks like this modification just works and still properly skips tests due to not having the log file repo. The only downside is the skip reason is less helpful now, e.g. instead of:we now get:
I'm open to alternative solutions. I couldn't come up with anything that allows us to detect the presence of the log repo from inside a decorator like that.